Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Update with latest cryptol_client, fix types #1550

Merged
merged 12 commits into from
Jan 4, 2022
Merged

[RPC] Update with latest cryptol_client, fix types #1550

merged 12 commits into from
Jan 4, 2022

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Dec 23, 2021

This PR updates the SAW RPC Python API with the latest version of the Cryptol RPC Python API. Summarizing the most relevant change, what was written before as:

cryptol("(@)")(res, cryptol("0"))
cryptol("`{i}:[64]".format(i=length))
i < cryptol("512")

would now be written as:

cry_f("{res}@0")
cry_f("`{length}:[64]")
cry_f("{i} < 512")

This PR also adds precondition_f, postcondition_f, and returns_f, which are just shorthands for precondition(cry_f(...)), postcondition(cry_f(...)), and returns(cry_f(...)). For example, what was written before as:

self.precondition(i < cryptol("512"))

would now be written as:

self.precondition_f("{i} < 512")

Additionally, this PR updates various parts of the library and tests to get everything to typecheck with mypy, and makes some types more explicit where possible.

@m-yac m-yac added the subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings label Dec 23, 2021
@m-yac m-yac requested a review from pnwamk December 23, 2021 22:43
pnwamk
pnwamk approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@pnwamk pnwamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is awesome. Just a few minor comments I'm happy with you addressing however you see fit. (Happy to chat more about tradeoffs too, but don't feel blocked by me over something trivial.)

@RyanGlScott
Update saw-remote-api/python/saw_client/crucible.py
4705427 
Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com>
@m-yac m-yac added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jan 4, 2022
@mergify mergify bot merged commit f7a0de1 into master Jan 4, 2022
@mergify mergify bot deleted the rpc/quoted-cryptol branch January 4, 2022 23:13
@chameco chameco mentioned this pull request Apr 24, 2022
Open
@RyanGlScott RyanGlScott mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnwamk pnwamk pnwamk approved these changes

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-yac @RyanGlScott @pnwamk